Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resampling - Part 1 #403

Closed
wants to merge 65 commits into from
Closed

Resampling - Part 1 #403

wants to merge 65 commits into from

Conversation

forman
Copy link
Member

@forman forman commented Feb 3, 2021

This is part one of two of a large breaking change in xcube that will allow for generic spatio-temporal resampling (#391). This part one concentrates on the implementation of spatial resampling. Part 2 will focus on combined spatio-temporal resampling and integration into the xcube gen2 tool.

Issues

Addresses #391
Addresses #112

Fixes #400

Major changes:

  • Numerous breaking changes have been applied to this version in order to address generic resampling (Temporal and spatial resampling  #391) and support other CRS than WGS-84 (Allow for other common spatial CRS #112):

    • The following components have been removed entirely
      • module xcube.core.imgeom with class ImageGeom
      • module xcube.core.geocoding with class GeoCoding
      • module xcube.core.reproject and all its functions
    • The following components have been added
      • module xcube.core.gridmapping with new class GridMapping
        is a CF compliant replacement for classes ImageGeom and GeoCoding
    • The following components have changed in an incompatible way:
      • Functionxcube.core.rectify.rectify_dataset() now uses
        source_gm: GridMapping and target_gm: GridMapping instead of
        geo_coding: GeoCoding and output_geom: ImageGeom.
      • Functionxcube.core.gen.iproc.InputProcessor.process() now uses
        source_gm: GridMapping and target_gm: GridMapping instead of
        geo_coding: GeoCoding and output_geom: ImageGeom.
    • xcube no longer depends on GDAL (at least not directly).
  • Removed example notebooks that used hard-coded local file paths. (Missing files for executing example notebooks #400)

  • Fixed unit tests broken by accident. (Unittest test_fetch_wmts_kvp_tile does not pass anymore #396)

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • [ ] New/modified features documented in docs/source/*
  • Changes documented in docs/CHANGES.md
  • AppVeyor and Travis CI passes
  • Test coverage remains or increases (target 100%)
  • Associated issues closed after merge

@forman forman self-assigned this Feb 3, 2021
@forman forman added important This is very important for the project urgent High external pressure to address this ASAP labels Feb 3, 2021
@forman forman removed the urgent High external pressure to address this ASAP label May 5, 2021
@forman
Copy link
Member Author

forman commented Jul 10, 2021

Closed in favour of PM #485

@forman forman closed this Jul 10, 2021
@forman forman deleted the forman-391-gridmapping branch August 30, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important This is very important for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing files for executing example notebooks
1 participant