-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resampling - Part 1 #403
Closed
Closed
Resampling - Part 1 #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_with_j_axis_down
# Conflicts: # examples/notebooks/rectify.ipynb
forman
added
important
This is very important for the project
urgent
High external pressure to address this ASAP
labels
Feb 3, 2021
Closed in favour of PM #485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part one of two of a large breaking change in xcube that will allow for generic spatio-temporal resampling (#391). This part one concentrates on the implementation of spatial resampling. Part 2 will focus on combined spatio-temporal resampling and integration into the xcube gen2 tool.
Issues
Addresses #391
Addresses #112
Fixes #400
Major changes:
Numerous breaking changes have been applied to this version in order to address generic resampling (Temporal and spatial resampling #391) and support other CRS than WGS-84 (Allow for other common spatial CRS #112):
xcube.core.imgeom
with classImageGeom
xcube.core.geocoding
with classGeoCoding
xcube.core.reproject
and all its functionsxcube.core.gridmapping
with new classGridMapping
is a CF compliant replacement for classes
ImageGeom
andGeoCoding
xcube.core.rectify.rectify_dataset()
now usessource_gm: GridMapping
andtarget_gm: GridMapping
instead ofgeo_coding: GeoCoding
andoutput_geom: ImageGeom
.xcube.core.gen.iproc.InputProcessor.process()
now usessource_gm: GridMapping
andtarget_gm: GridMapping
instead ofgeo_coding: GeoCoding
andoutput_geom: ImageGeom
.Removed example notebooks that used hard-coded local file paths. (Missing files for executing example notebooks #400)
Fixed unit tests broken by accident. (Unittest test_fetch_wmts_kvp_tile does not pass anymore #396)
Checklist:
[ ] New/modified features documented indocs/source/*
docs/CHANGES.md