Replace TypeSpecifier by simpler DataType #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forman
changed the title
This was referenced Aug 27, 2021
TonioF
reviewed
Aug 27, 2021
| @property | ||
| def alias(self) -> str: | ||
| """The primary alias name.""" | ||
| return self._aliases[0] |
There was a problem hiding this comment.
aliases might be of length 0
There was a problem hiding this comment.
No, there is always at least one alias. See constructor.
| fs_path = self._convert_data_id_into_fs_path(data_id) | ||
| return self.fs.exists(fs_path) | ||
| return False | ||
|
|
||
| def describe_data(self, data_id: str, type_specifier: str = None) \ | ||
| def describe_data(self, data_id: str, data_type: DataTypeLike = None) \ |
There was a problem hiding this comment.
We need to think about whether we still need data_type as a parameter here. We originally put it in here because the resulting DataDescriptor would be different, depending on whether we ask for a data or a dataset[cube].
There was a problem hiding this comment.
Actually, each datatype has its own descriptor type,
- xr.Dataset <-> DatasetDescriptor
- MultiLevelDataset <-> MultiLevelDatasetDescriptor
- gpd.GeoDataFrame <-> GeoDataFrameDatasetDescriptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #509
This PR implements more or less the solution indicated in #509.
Checklist:
docs/source/*CHANGES.mdRemember to close associated issues after merge!