Toniof 516 unify datasetio #527
Conversation
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
==========================================
+ Coverage 91.51% 91.69% +0.17%
==========================================
Files 288 288
Lines 26271 26426 +155
==========================================
+ Hits 24043 24230 +187
+ Misses 2228 2196 -32
Continue to review full report at Codecov.
|
| return self._dataset_configs | ||
|
|
||
| def _maybe_assign_store_instance_ids(self): |
There was a problem hiding this comment.
Long, complex method. Please refactor and/or add comments so one can understand the algorithm implementation. It takes me too much time to reverse-engineer the intentions coded here.
xcube/core/store/storepool.py
Outdated
| def get_store_instance_id(self, | ||
| store_config: DataStoreConfig, | ||
| strict_check: bool = False | ||
| ) \ | ||
| -> Optional[str]: |
There was a problem hiding this comment.
Code style:
| def get_store_instance_id(self, | |
| store_config: DataStoreConfig, | |
| strict_check: bool = False | |
| ) \ | |
| -> Optional[str]: | |
| def get_store_instance_id(self, | |
| store_config: DataStoreConfig, | |
| strict_check: bool = False | |
| ) \ | |
| -> Optional[str]: |
| def get_store_instance_id(self, | |
| store_config: DataStoreConfig, | |
| strict_check: bool = False | |
| ) \ | |
| -> Optional[str]: | |
| def get_store_instance_id( | |
| self, | |
| store_config: DataStoreConfig, | |
| strict_check: bool = False | |
| ) -> Optional[str]: |
There was a problem hiding this comment.
GitHub has a bug here: it doubles the suggestions! Only the second is valid!
There was a problem hiding this comment.
I just wanted to check our code style for this issue. I did not find it, I just recall we already talked about this before.
But are you certain that the suggestion below is right? Going to the lowest indention level with the method header?
There was a problem hiding this comment.
I did not find it, I just recall we already talked about this before.
PEP-8. And yes, we talked about this before, see https://www.python.org/dev/peps/pep-0008/#indentation
Going to the lowest indention level with the method header?
No that's not right, it happened per accident.
There was a problem hiding this comment.
Okay, changed it according to pep8
# Conflicts: # examples/serve/demo/config-with-stores.yml
…-datasetio"" This reverts commit 4c67c0a
This PR addresses #516. It ensures that, if a Configuration with Datasets is passed to a ServiceContext, each dataset is assigned to a datastore that will be used to open the data (unless the dataset is in-memory). It is attempted to find common roots for data stores to group datasets located at same/similar locations together.
When reviewing this, please consider especially the function get_data_store_pool of the ServerContext: This function used to remove a data store pool if there were no datastores explicitly configured. I had to change this, but I don't fully understand what was the original reasoning behind this.
Checklist:
[ ] Add docstrings and API docs for any new/modified user-facing classes and functions[ ] New/modified features documented indocs/source/*CHANGES.mdRemember to close associated issues after merge!