Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced parameter "base_dataset_id" for writing multi-level datasets #622

Merged
merged 8 commits into from
Mar 1, 2022
Merged

Introduced parameter "base_dataset_id" for writing multi-level datasets #622

merged 8 commits into from
Mar 1, 2022

Conversation

forman
Copy link
Member

@forman forman commented Feb 24, 2022 •
edited
Loading

Introduced parameter "base_dataset_id" for writing multi-level datasets.

This is a first step to address #617. In a next step, xcube level CLI tool should use the data store framework.

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in CHANGES.md
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

Remember to close associated issues after merge!

@forman forman requested a review from TonioF February 25, 2022 08:54
@forman forman self-assigned this Feb 25, 2022
@forman forman marked this pull request as ready for review February 28, 2022 07:32
TonioF
TonioF requested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@TonioF TonioF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have the error with the inconsistent number of detail levels. Can you please set the chunking explicitly?

@forman
Copy link
Member Author

forman commented Feb 28, 2022 •
edited
Loading

I still have the error with the inconsistent number of detail levels. Can you please set the chunking explicitly?

That has been done. CI is also green.

See https://github.com/dcs4cop/xcube/blob/44540f0390099fa659989f55241d998cc6e8f50e/test/core/store/fs/test_registry.py#L198-L201

@forman forman requested a review from TonioF February 28, 2022 16:40
TonioF
TonioF approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@TonioF TonioF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it's all working now.

@forman
Copy link
Member Author

forman commented Mar 1, 2022

Merging although conda repo for Linux-64 seems broken. On Mac OS, AppVeyor is green.

@forman forman merged commit ff02034 into master Mar 1, 2022
@forman forman deleted the forman-617-levels_on_s3 branch March 2, 2022 17:42
@forman forman mentioned this pull request Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonioF TonioF TonioF approved these changes

Assignees

@forman forman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@forman @TonioF