Resolve relative links used by multi-level datasets as specified #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 91.91% 91.96% +0.04%
==========================================
Files 293 294 +1
Lines 27026 27090 +64
==========================================
+ Hits 24840 24912 +72
+ Misses 2186 2178 -8
Continue to review full report at Codecov.
|
# Conflicts: # docs/source/mldatasets.md
TonioF
approved these changes
Mar 7, 2022
| def get_fs_path_class(fs: fsspec.AbstractFileSystem) \ | ||
| -> Type[pathlib.PurePath]: | ||
| """ | ||
| Get the appropriate ``pathlib.PurePath`` class for the filesystem *fs*. |
There was a problem hiding this comment.
Suggested change
| Get the appropriate ``pathlib.PurePath`` class for the filesystem *fs*. | |
| Get the appropriate ``pathlib.PurePath`` class. |
This method also returns the appropriate path class for other file systems.
There was a problem hiding this comment.
This method also returns the appropriate path class for other file systems.
What other filesystems? There is only one argument named fs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Description of PR]
Checklist:
docs/source/*CHANGES.mdRemember to close associated issues after merge!