-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "xcube level" tool with S3 #649
Conversation
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
==========================================
- Coverage 91.96% 91.95% -0.01%
==========================================
Files 298 298
Lines 27335 27400 +65
==========================================
+ Hits 25138 25197 +59
- Misses 2197 2203 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions for improvement, but overall it looks good!
|
||
|
||
@deprecated(version=_DEPRECATED_SINCE, reason=_DEPRECATED_WRITE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason does not match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, becasue it was used when writing only.
@@ -45,6 +46,12 @@ | |||
from xcube.util.perf import measure_time | |||
from xcube.util.tilegrid import TileGrid | |||
|
|||
_DEPRECATED_VERSION = '0.10.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As there is the theoretical possibility that we might have different deprecation versions in the same module, I'd propose to consider this in the name. Or even put this in a dedicated module somewhere, so we really only have to declare it once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a private constant and it stands for exactly one constant value used here. If we need more versions one day, we can easily add more constants.
Co-authored-by: Tonio Fincke <tonio.fincke@brockmann-consult.de>
This PR closes #617 and addresses #516:
The
xcube level
CLI tool has been rewritten from scratch to make useof xcube filesystem data stores. (Allow creating pyramids on S3 #617)
Deprecated numerous classes and functions around multi-level datasets.
The non-deprecated functions and classes of
xcube.core.mldataset
shouldbe used instead along with the xcube filesystem data stores for
multi-level dataset i/o. (Unify xcube dataset i/o #516)
xcube.core.level
modulecompute_levels()
read_levels()
write_levels()
xcube.core.mldataset
module
FileStorageMultiLevelDataset
ObjectStorageMultiLevelDataset
open_ml_dataset()
open_ml_dataset_from_object_storage()
open_ml_dataset_from_local_fs()
write_levels()
Support for multi-level datasets has been improved:
num_levels
: If given, restricts the number of resolution levelsto the given value. Must be a positive integer to be effective.
Closes #617.
Checklist:
CHANGES.md
FYI @AliceBalfanz @pont-us