Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow "xcube serve" to serve cubes given via CLI paths #68

Merged
merged 7 commits into from
May 17, 2019

Conversation

forman
Copy link
Member

@forman forman commented May 15, 2019

This is a prerequisite for other QC and performance measurement tools related to solving #52 (PR will follow soon).

@AliceBalfanz please merge after review.

Copy link
Contributor

@AliceBalfanz AliceBalfanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One test still failing, please fix before merging.

@forman
Copy link
Member Author

forman commented May 16, 2019

@AliceBalfanz once again, please!

@codecov-io
Copy link

codecov-io commented May 16, 2019

Codecov Report

Merging #68 into master will decrease coverage by 0.1%.
The diff coverage is 59.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #68      +/-   ##
=========================================
- Coverage    84.6%   84.5%   -0.11%     
=========================================
  Files          70      70              
  Lines        5976    6021      +45     
=========================================
+ Hits         5056    5088      +32     
- Misses        920     933      +13
Impacted Files Coverage Δ
xcube/webapi/defaults.py 100% <ø> (ø) ⬆️
xcube/cli/serve.py 67.64% <42.85%> (+4.31%) ⬆️
xcube/webapi/context.py 78.34% <52.17%> (-0.95%) ⬇️
xcube/webapi/service.py 60.36% <71.42%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d1878...b77c4be. Read the comment docs.

Copy link
Contributor

@AliceBalfanz AliceBalfanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@AliceBalfanz AliceBalfanz merged commit 69f5c3d into master May 17, 2019
@forman forman deleted the forman-serve_wo_config branch May 21, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants