-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Providing compatibility with Python 3.10 #771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Do these changes change anything about this: https://github.com/dcs4cop/xcube/blob/cc3690c6ad889121b66511ad7a08c384a1ba5ac2/test/core/store/fs/test_subset.py#L164 , though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, with one optional suggestion.
@@ -4,7 +4,7 @@ channels: | |||
- defaults | |||
dependencies: | |||
# Python | |||
- python >=3.8,<3.10 | |||
- python >=3.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- python >=3.8 | |
- python >=3.8,<3.11 |
Currently, creating an xcube environment with the one-sided >=3.8
limit installs Python 3.10, I assume because something in the dependencies is currently requiring python <3.11
. That dependency will one day suddenly start supporting Python 3.11 and new xcube environments will start getting Python 3.11 by default with no changes on our side. That seems dangerous, so I suggest including the upper limit, but I leave the decision to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something in the dependencies is currently requiring
python <3.11
It would be interesting to know what that something is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be interesting to know what that something is.
Agreed -- I considered investigating, but decided against it since explorations of conda dependency structures can get quite time-consuming.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you know, Python 3.11 is not working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not, we stay with python >=3.8
and fix any issues with 3.11
when they occur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know that Python 3.11 is not working, but I also don't know how to test that it will work. So if you want to take the chance we can leave it without the upper limit :)
I don't know. But we should find out after merging. |
Majority of issues come from outdated
moto
. Now, with currentmoto >=4
, we run into aio-libs/aiobotocore#755 with no obvious solution.Closes #583
Checklist:
CHANGES.md
(will add after merge, so we don't need CI once more)