Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forman 92 xcube prune #93

Merged
merged 6 commits into from
Jun 17, 2019
Merged

Forman 92 xcube prune #93

merged 6 commits into from
Jun 17, 2019

Conversation

forman
Copy link
Member

@forman forman commented Jun 16, 2019

Added new CLI command xcube prune. The tool deletes all block files associated with empty (NaN-
only) chunks in given INPUT cube, which must have ZARR format. This can drastically reduce files
in sparse cubes and improve cube reading performance.

Closes #92.

@AliceBalfanz and @dzelge could you please complete your PR until tomorrow evening, because I'd like to demo and use it on Tuesday.

@TonioF, FYI.

@codecov-io
Copy link

codecov-io commented Jun 16, 2019

Codecov Report

Merging #93 into master will increase coverage by 0.12%.
The diff coverage is 94.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   84.84%   84.96%   +0.12%     
==========================================
  Files          68       69       +1     
  Lines        6056     6134      +78     
==========================================
+ Hits         5138     5212      +74     
- Misses        918      922       +4
Impacted Files Coverage Δ
xcube/cli/cli.py 83.67% <100%> (+0.22%) ⬆️
xcube/api/chunk.py 100% <100%> (ø) ⬆️
xcube/cli/prune.py 91.48% <91.48%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f3c9b0...1be98be. Read the comment docs.

Copy link
Contributor

@AliceBalfanz AliceBalfanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks! :)

@forman forman merged commit bbef679 into master Jun 17, 2019
@forman
Copy link
Member Author

forman commented Jun 17, 2019

Merging as I need it tomorrow...

@forman forman deleted the forman-92-xcube_prune branch June 20, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete empty ZARR chunks
4 participants