Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing roots to xcube.webapi.viewer.Viewer #991

Merged
merged 7 commits into from
Jun 4, 2024

Conversation

forman
Copy link
Member

@forman forman commented May 29, 2024

The class xcube.webapi.viewer.Viewer now accepts root paths or URLs that will each be scanned for datasets. The roots are passed as keyword argument roots whose value is a path or URL or an iterable of paths or URLs. A new keyword argument max_depth defines the maximum subdirectory depths used to search for datasets in case roots is given. It defaults to 1.

Closes #990

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@forman forman self-assigned this May 29, 2024
@forman forman marked this pull request as ready for review May 30, 2024 12:43
@forman forman requested a review from TejasMorbagal May 31, 2024 12:37
Copy link
Contributor

@TejasMorbagal TejasMorbagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works. The feature can be handy for viewing smaller datasets, but for larger once loading of datasets is slower, which is expected.

@forman
Copy link
Member Author

forman commented Jun 4, 2024

Thanks!

@forman forman merged commit f92cf10 into main Jun 4, 2024
3 checks passed
@forman forman deleted the forman-990-ease_viewer_usage branch July 4, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve usability of xcube Viewer in Jupyter Lab
2 participants