Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No error if no params to async action were passed #26

Open
alxmiron opened this issue Mar 21, 2020 · 1 comment
Open

No error if no params to async action were passed #26

alxmiron opened this issue Mar 21, 2020 · 1 comment

Comments

@alxmiron
Copy link

In the main example from the readme, if I dispatch a login action without params, no errors will be thrown:

await store.dispatch(login());

because login action creator has optional params type (in some reason)

const login: ThunkFunction
   (params?: LoginParams | undefined) => ...

It seems like a bug. It's not type-safe.
See a repro case here: https://codesandbox.io/s/typescript-mzr5r

@septs septs mentioned this issue Aug 16, 2020
8 tasks
@septs
Copy link
Contributor

septs commented Aug 17, 2020

@xdave the issue may be solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants