-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve 2 #30
Improve 2 #30
Conversation
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 22 23 +1
Branches 1 1
=========================================
+ Hits 22 23 +1
Continue to review full report at Codecov.
|
i think the two dependency, need move to peer dependency because of |
smart factory function new feature, fixes #26 My two pull requests, contains two break changes I think should be iterated to |
rename generic, can make the user better understand his meaning |
Whoa this is a big one. Reviewing. |
I'll merge this, if you're done pushing things |
@xdave smart thunk function is a new break changes const foo = createAsync('foo', (input: undefined) => '');
foo // (input: undefined) => string
foo() // Expected 1 arguments, but got 0. ts(2554)
foo(undefined)
// but can be used like this
const bar = createAsync('bar', (input: string | void) => '');
bar // (input: string | void) => string
bar() // like is optional params
bar('sample') |
Hmm, seeing |
@xdave if I could know that there is an |
No, that's fine... let me merge this and make the 2.10.0 release |
if
P
equalunknown
thenreturns a
ThunkFunction
without params inputelse
returns a
ThunkFunction
with require params input