Add support for runInTerminal request

[felixfbecker]

Closes #60

• externalConsole is now deprecated
• you can now run your program in the integrated terminal

[felixfbecker]

@weinand Does the testsupport already support the runInTerminal request?

[weinand]

@felixfbecker not yet. Since this is the first 'reverse' request, it needs some work to provide support for this...

[felixfbecker]

@weinand that's unfortunate, I thought that it is implemented in the node debugger would mean you also have tests for that. Cannot merge this because it seems to break the tests completely even though everything works fine.

[weinand]

@felixfbecker I do not understand what you mean and why it breaks something.
The runInTerminal is implemented in VS Code and node-debug is calling it. The test support is independent from VS Code so it has to implement 'runInTerminal' itself.

[felixfbecker]

runInTerminal is implemented in node-debug. So I assumed you had tests for that in the test suite of the node-debug, so I assumed the testsupport would support it.

The failing tests were a bug on my side though, sorry. I just don't feel very confident merging this as I can't write any tests without testsupport...

[felixfbecker]

@weinand Is there a way to highlight the externalConsole attribute as deprecated like for the Node debugger? Something like "deprecated": true in the JSON schema?

[codecov-io]

Codecov Report

Merging #67 into master will increase coverage by 12.74%.
The diff coverage is 84.37%.

@@             Coverage Diff             @@
##           master      #67       +/-   ##
===========================================
+ Coverage   62.28%   75.03%   +12.74%     
===========================================
  Files           5        4        -1     
  Lines         830      733       -97     
  Branches      138      125       -13     
===========================================
+ Hits          517      550       +33     
+ Misses        256      182       -74     
+ Partials       57        1       -56

Impacted Files	Coverage Δ
src/phpDebug.ts	66.66% <84.37%> (+8.09%)	⬆️
src/xdebugConnection.ts	81.11% <0%> (+3.43%)	⬆️
src/paths.ts	100% <0%> (+5.71%)	⬆️
src/dbgp.ts	94.82% <0%> (+12.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02acaf3...1a19fc3. Read the comment docs.

[zobo]

Closing in favor of #966