New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add charset options lc_type and lc_decode to createConnection #95

Merged

xdenser merged 2 commits into xdenser:master from mjschutz:charset-options

Nov 20, 2019

Contributor

mjschutz commented Oct 31, 2019

Hi.

I made changes to support options on createConnection to change lc_type and a lc_decode function to decode the result buffer to string. Example:

let connection = Firebird.createConnection({ lc_type: 'WIN1252', lc_decode: (data) => iconv.decode(data, 'windows-1252') });

I run tests here and the code is working fine (node 12), this will probably resolve the issues #9 and #87


          Add charset options lc_type and lc_decode to createConnection

1d81176

Contributor Author

mjschutz commented Oct 31, 2019

I will check the problem with the assync version of connection, and commit a fix.


          Fix async connection with lc_type

20cc25e

xdenser merged commit 71c419e into xdenser:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet