Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Video and Image diemensions field in respective class #272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/twitter-ads/creative/image_conversation_card.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ class ImageConversationCard
property :third_cta
property :third_cta_tweet
property :title
property :image_display_height
property :image_display_width

RESOURCE_COLLECTION = "/#{TwitterAds::API_VERSION}/" \
'accounts/%{account_id}/cards/image_conversation' # @api private
Expand Down
2 changes: 2 additions & 0 deletions lib/twitter-ads/creative/video_conversation_card.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ class VideoConversationCard
property :third_cta_tweet
property :title
property :media_key
property :video_width
property :video_height

RESOURCE_COLLECTION = "/#{TwitterAds::API_VERSION}/" \
'accounts/%{account_id}/cards/video_conversation' # @api private
Expand Down