fix failing test case

xdslproject · Jun 21, 2022 · 50ab2fc · 50ab2fc
1 parent 52bfe7d
commit 50ab2fc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/xdsl/irdl.py b/src/xdsl/irdl.py
@@ -902,6 +902,10 @@ def irdl_data_definition(cls: type[T]) -> type[T]:
                 raise Exception(f'In {cls.__name__} definition: Cannot infer '
                                 f'"verify" method. Type parameter of Data is '
                                 f'not a class.')
+            if isinstance(expected_type, types.GenericAlias):
+                raise Exception(f'In {cls.__name__} definition: Cannot infer '
+                                f'"verify" method. Type parameter of Data has '
+                                f'type GenericAlias.')
             new_attrs[
                 "verify"] = lambda self, expected_type=expected_type: irdl_data_verify(
                     self, expected_type)

diff --git a/tests/attribute_definition_test.py b/tests/attribute_definition_test.py
@@ -117,7 +117,8 @@ def test_data_with_non_class_param_missing_verifier_failure():
         irdl_attr_definition(IntListMissingVerifierData)
     assert e.value.args[0] == (
         'In IntListMissingVerifierData definition: '
-        'Cannot infer "verify" method. Type parameter of Data is not a class.')
+        'Cannot infer "verify" method. Type parameter of Data has type GenericAlias.'
+    )
 
 
 @irdl_attr_definition