Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: Move to signless types in riscv dialect #1216

Closed
JosseVanDelm opened this issue Jun 29, 2023 · 2 comments
Closed

riscv: Move to signless types in riscv dialect #1216

JosseVanDelm opened this issue Jun 29, 2023 · 2 comments
Labels
dialects Changes on the dialects good first issue Good for newcomers

Comments

@JosseVanDelm
Copy link
Collaborator

It was pointed out in #1212 that some ops (e.g. LiOp) will lower to have signed types.
This makes little sense, since the RISC-V instruction set itself does not attach sign semantics to the values in its registers. This is the exact reason why LLVM dialect does not use signs, and why using signs in arith does not even verify in mlir.

Therefore I feel like all signs (e.g. si32 types) in riscv dialect should be omitted, since sign semantics are preserved in the riscv ops themselves anyway.

@JosseVanDelm JosseVanDelm added good first issue Good for newcomers dialects Changes on the dialects labels Jun 29, 2023
@JosseVanDelm
Copy link
Collaborator Author

JosseVanDelm commented Aug 3, 2023

@rgantonio

@superlopuh
Copy link
Member

Fixed in #2100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants