Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: We need more variadic inference for compatibility #3064

Closed
PapyChacal opened this issue Aug 19, 2024 · 0 comments · Fixed by #3067 or #3070
Closed

core: We need more variadic inference for compatibility #3064

PapyChacal opened this issue Aug 19, 2024 · 0 comments · Fixed by #3067 or #3070
Labels
core xDSL core (ir, textual format, ...) dialects Changes on the dialects

Comments

@PapyChacal
Copy link
Collaborator

PapyChacal commented Aug 19, 2024

Symptom: xDSL's memref.extract_strided_metadata is incompatible with MLIR's

(I wasn't sure which one should be title or subtitle)

Introduced by:

This operation has two variadic results, which in xDSL enforces to have

    irdl_options = [AttrSizedResultSegments()]

And thus expect the related attribute.

Except MLIR prints it without it:

%1:6 = "memref.extract_strided_metadata"(%0) : (memref<512x384xi32>) -> (memref<i32>, index, index, index, index, index)

What trickery is this, you might ask 🧙

Well they provide an internal trait SameVariadicResultSize, bypassing the need of an explicit encoding of each variadic result's size here, because as cleary stated by the name, one can just infer it easily.

Except xDSL cannot at the moment. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...) dialects Changes on the dialects
Projects
None yet
1 participant