-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: Implement IRDL SameSize options #3067
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
==========================================
- Coverage 89.88% 89.87% -0.02%
==========================================
Files 418 418
Lines 52581 52657 +76
Branches 8134 8153 +19
==========================================
+ Hits 47261 47324 +63
- Misses 4009 4018 +9
- Partials 1311 1315 +4 ☔ View full report in Codecov by Sentry. |
LGTM, I would just add a test with 2 variadics and 1 non variadic! |
I directly added a non-variadic between the two variadics instead to avoid bloating! I also added a test for the verification exception. |
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
Should help fix:
(Hey GitHub, I said should help fix #3064?)