Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Implement IRDL SameSize options #3067

Merged
merged 8 commits into from
Aug 20, 2024
Merged

core: Implement IRDL SameSize options #3067

merged 8 commits into from
Aug 20, 2024

Conversation

PapyChacal
Copy link
Collaborator

@PapyChacal PapyChacal commented Aug 19, 2024

Should help fix:

(Hey GitHub, I said should help fix #3064?)

@PapyChacal PapyChacal added the core xDSL core (ir, textual format, ...) label Aug 19, 2024
@PapyChacal PapyChacal self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (77ae3a5) to head (966555a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
- Coverage   89.88%   89.87%   -0.02%     
==========================================
  Files         418      418              
  Lines       52581    52657      +76     
  Branches     8134     8153      +19     
==========================================
+ Hits        47261    47324      +63     
- Misses       4009     4018       +9     
- Partials     1311     1315       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@math-fehr
Copy link
Collaborator

LGTM, I would just add a test with 2 variadics and 1 non variadic!

@PapyChacal PapyChacal marked this pull request as ready for review August 20, 2024 12:16
@PapyChacal PapyChacal changed the title [WIP] core: Implement IRDL SameSize options core: Implement IRDL SameSize options Aug 20, 2024
@PapyChacal
Copy link
Collaborator Author

LGTM, I would just add a test with 2 variadics and 1 non variadic!

I directly added a non-variadic between the two variadics instead to avoid bloating!

I also added a test for the verification exception.

xdsl/irdl/operations.py Outdated Show resolved Hide resolved
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
@PapyChacal PapyChacal merged commit 8fc70cd into main Aug 20, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/samesize branch August 20, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: We need more variadic inference for compatibility
3 participants