Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined cmath with the IRDL from xDSL + added tests #127

Merged
merged 9 commits into from
Jun 30, 2022

Conversation

purvi-H
Copy link
Contributor

@purvi-H purvi-H commented Jun 24, 2022

Wrote and registered the cmath dialect + tested its operations.

Copy link
Contributor

@tobiasgrosser tobiasgrosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Thank you for this PR.

tests/filecheck/.lit_test_times.txt Outdated Show resolved Hide resolved
tests/filecheck/cmath.xdsl Outdated Show resolved Hide resolved
Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the comments we sent?
Also, could you format your files using yapf, so it passes the CI?

src/xdsl/dialects/cmath.py Outdated Show resolved Hide resolved
src/xdsl/dialects/cmath.py Outdated Show resolved Hide resolved
src/xdsl/dialects/cmath.py Outdated Show resolved Hide resolved
tests/filecheck/cmath.xdsl Outdated Show resolved Hide resolved
tests/filecheck/.lit_test_times.txt Outdated Show resolved Hide resolved
src/xdsl/dialects/cmath.py Outdated Show resolved Hide resolved
@purvi-H purvi-H requested a review from math-fehr June 28, 2022 13:58
@math-fehr math-fehr merged commit 8cb869a into xdslproject:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants