Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialects: (riscv) canonicalization pattern added (x+x=x*2) #1566

Merged
merged 2 commits into from
Sep 11, 2023
Merged

dialects: (riscv) canonicalization pattern added (x+x=x*2) #1566

merged 2 commits into from
Sep 11, 2023

Conversation

dshaaban01
Copy link
Collaborator

No description provided.

@dshaaban01 dshaaban01 added the dialects Changes on the dialects label Sep 11, 2023
@dshaaban01 dshaaban01 self-assigned this Sep 11, 2023
tobiasgrosser
tobiasgrosser approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@tobiasgrosser tobiasgrosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. A first commit within less than a day. 🎉 I guess others may have more style comments, but the direction is certainly already great.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
xdsl/dialects/riscv.py 100.00%
xdsl/transforms/canonicalization_patterns/riscv.py 100.00%

📢 Thoughts on this report? Let us know!.

superlopuh
superlopuh approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@superlopuh superlopuh merged commit ed436e6 into main Sep 11, 2023
10 checks passed
@superlopuh superlopuh deleted the dalia/risc-5-canonicalization branch September 11, 2023 14:20
@superlopuh superlopuh mentioned this pull request Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazavode nazavode nazavode approved these changes

@superlopuh superlopuh superlopuh approved these changes

@tobiasgrosser tobiasgrosser tobiasgrosser approved these changes

@compor compor Awaiting requested review from compor

Assignees

@dshaaban01 dshaaban01

Labels
dialects Changes on the dialects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dshaaban01 @tobiasgrosser @superlopuh @nazavode