Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialects: (riscv) add canonicalization pattern x*0=0 #1567

Merged
merged 3 commits into from
Sep 11, 2023
Merged

dialects: (riscv) add canonicalization pattern x*0=0 #1567

merged 3 commits into from
Sep 11, 2023

Conversation

luisacicolini
Copy link
Collaborator

No description provided.

@luisacicolini luisacicolini added the dialects Changes on the dialects label Sep 11, 2023
@luisacicolini luisacicolini self-assigned this Sep 11, 2023
tobiasgrosser
tobiasgrosser approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@tobiasgrosser tobiasgrosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. How nice to see a patch on day one. This looks good to me. Let's wait if others have feedback. (also there was a ci hickup. I restarted it and hope it will go through this time)

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Patch coverage is 90.90% of modified lines.

Files Changed Coverage
xdsl/transforms/canonicalization_patterns/riscv.py 88.88%
xdsl/dialects/riscv.py 100.00%

📢 Thoughts on this report? Let us know!.

superlopuh
superlopuh approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@superlopuh superlopuh merged commit 06e03f7 into xdslproject:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasgrosser tobiasgrosser tobiasgrosser approved these changes

@superlopuh superlopuh superlopuh approved these changes

@adutilleul adutilleul adutilleul approved these changes

@nazavode nazavode Awaiting requested review from nazavode

@compor compor Awaiting requested review from compor

Assignees

@luisacicolini luisacicolini

Labels
dialects Changes on the dialects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luisacicolini @tobiasgrosser @superlopuh @adutilleul