Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialects: switch llvm to properties. #1874

Merged
merged 2 commits into from
Dec 15, 2023
Merged

dialects: switch llvm to properties. #1874

merged 2 commits into from
Dec 15, 2023

Conversation

PapyChacal
Copy link
Collaborator

Mh, we're lacking MLIR interop tests I guess 🤔

@PapyChacal PapyChacal added the dialects Changes on the dialects label Dec 15, 2023
@PapyChacal PapyChacal self-assigned this Dec 15, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fbbe88) 89.28% compared to head (2b3aecb) 89.28%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1874   +/-   ##
=======================================
  Coverage   89.28%   89.28%           
=======================================
  Files         275      275           
  Lines       33267    33267           
  Branches     4972     4972           
=======================================
  Hits        29701    29701           
  Misses       2830     2830           
  Partials      736      736

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AntonLydike
AntonLydike approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@AntonLydike AntonLydike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@PapyChacal PapyChacal marked this pull request as ready for review December 15, 2023 15:28
@PapyChacal PapyChacal merged commit c174eb6 into main Dec 15, 2023
10 checks passed
@PapyChacal PapyChacal deleted the emilien/lllvm-updates branch December 15, 2023 15:56
@ed741 ed741 mentioned this pull request Feb 12, 2024
Merged
math-fehr pushed a commit that referenced this pull request Feb 13, 2024
@ed741
dialects: (LLVM) Fix use of attributes dict when dialect specifies pr…
91a563f 
…op_def (#2144)

Fixes use of attributes dict when dialect specifies prop_def for:
llvm.extractvalue
llvm.insertvalue

Seems like a bug left over from #1874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntonLydike AntonLydike AntonLydike approved these changes

@compor compor compor approved these changes

@superlopuh superlopuh Awaiting requested review from superlopuh

Assignees

@PapyChacal PapyChacal

Labels
dialects Changes on the dialects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PapyChacal @compor @AntonLydike