dialects: (onnx) add onnx.MaxPoolSingleOut #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2072 +/- ##
==========================================
+ Coverage 90.04% 90.05% +0.01%
==========================================
Files 292 292
Lines 36484 36552 +68
Branches 5415 5433 +18
==========================================
+ Hits 32851 32918 +67
+ Misses 2860 2858 -2
- Partials 773 776 +3 ☔ View full report in Codecov by Sentry. |
superlopuh
reviewed
Feb 1, 2024
superlopuh
approved these changes
Feb 1, 2024
Co-authored-by: Sasha Lopoukhine <superlopuh@gmail.com>
compor
approved these changes
Feb 1, 2024
| @@ -64,3 +65,5 @@ | |||
| %res_constant = "onnx.Constant"() {onnx_node_name = "/Constant", "value" = dense<1> : tensor<1xi64>}: () -> tensor<1xi64> | |||
| //CHECK: %res_constant = onnx.Constant() {"onnx_node_name" = "/Constant", "value" = dense<1> : tensor<1xi64>}: () -> tensor<1xi64> | |||
|
|
|||
| %res_max_pool_single_out = "onnx.MaxPoolSingleOut"(%t26) {onnx_node_name = "/MaxPoolSingleOut", "auto_pad" = "VALID", "ceil_mode" = 0 : i64, "kernel_shape" = [3 : i64, 3 : i64], "dilations" = [1 : i64, 1 : i64], "pads" = [0 : i64, 0 : i64, 0 : i64, 0 : i64], "storage_order" = 0 : i64, "strides" = [1 : i64, 1 : i64]}: (tensor<5x5x32x32xf32>) -> tensor<5x5x30x30xf32> | |||
| //CHECK: %res_max_pool_single_out = onnx.MaxPoolSingleOut(%t26) {"onnx_node_name" = "/MaxPoolSingleOut", "auto_pad" = "VALID", "ceil_mode" = 0 : i64, "kernel_shape" = [3 : i64, 3 : i64], "dilations" = [1 : i64, 1 : i64], "pads" = [0 : i64, 0 : i64, 0 : i64, 0 : i64], "storage_order" = 0 : i64, "strides" = [1 : i64, 1 : i64]}: (tensor<5x5x32x32xf32>) -> tensor<5x5x30x30xf32> | |||
There was a problem hiding this comment.
it might be a good idea to check filecheck substitution patterns (https://www.llvm.org/docs/CommandGuide/FileCheck.html#filecheck-regex-matching-syntax).
It can save some typing when changing names, etc and make the checks for flexible.
You don't have to change this here now, just something for the future.
Co-authored-by: Chris Vasiladiotis <cvassiladiotis@gmail.com>
Co-authored-by: Chris Vasiladiotis <cvassiladiotis@gmail.com>
…to oke/onnx-max-pool-single-out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2068