Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialects (riscv_cf): Allow float register types for block argument types #2083

Merged
merged 3 commits into from
Feb 2, 2024
Merged

dialects (riscv_cf): Allow float register types for block argument types #2083

merged 3 commits into from
Feb 2, 2024

Conversation

compor
Copy link
Collaborator

@compor compor commented Feb 2, 2024

This PR:

  • Allows float register types for block argument types
  • Filecheck test of the above

@compor compor added dialects Changes on the dialects backend Compiler backend in xDSL labels Feb 2, 2024
@compor compor added this to the riscv snitch rebuttal milestone Feb 2, 2024
@compor compor self-assigned this Feb 2, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2977f98) 90.09% compared to head (341d11d) 90.09%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2083   +/-   ##
=======================================
  Coverage   90.09%   90.09%           
=======================================
  Files         293      293           
  Lines       36596    36596           
  Branches     5437     5437           
=======================================
  Hits        32971    32971           
  Misses       2851     2851           
  Partials      774      774

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@compor compor merged commit 92c4b7d into main Feb 2, 2024
10 checks passed
@compor compor deleted the christos/riscv/riscv-cf-float-block-args branch February 2, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superlopuh superlopuh superlopuh approved these changes

@nazavode nazavode Awaiting requested review from nazavode

@AntonLydike AntonLydike Awaiting requested review from AntonLydike

@JosseVanDelm JosseVanDelm Awaiting requested review from JosseVanDelm

@adutilleul adutilleul Awaiting requested review from adutilleul

Assignees

@compor compor

Labels
backend Compiler backend in xDSL dialects Changes on the dialects
Projects
linalg.generic to riscv
Status: Done
Milestone
riscv snitch rebuttal
Development

Successfully merging this pull request may close these issues.
2 participants
@compor @superlopuh