dialects: (arith) adding an arith canonicalisation pattern #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshaaban01
requested review from
tobiasgrosser,
superlopuh,
compor,
math-fehr and
webmiche
dshaaban01
changed the base branch from
main
to
dalia/interactive_individual_rewrite_1
superlopuh
changed the title
superlopuh
added
dialects
superlopuh
requested changes
Feb 6, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dalia/interactive_individual_rewrite_1 #2094 +/- ##
==========================================================================
- Coverage 90.13% 90.12% -0.01%
==========================================================================
Files 296 297 +1
Lines 36799 36779 -20
Branches 5464 5461 -3
==========================================================================
- Hits 33168 33148 -20
+ Misses 2853 2852 -1
- Partials 778 779 +1 ☔ View full report in Codecov by Sentry. |
…ractive_add_arith_canon_2
…ractive_add_arith_canon_2
…ractive_add_arith_canon_2
…ractive_add_arith_canon_2
math-fehr
reviewed
Feb 6, 2024
math-fehr
approved these changes
Feb 6, 2024
superlopuh
approved these changes
Feb 6, 2024
…ractive_add_arith_canon_2
Base automatically changed from
dalia/interactive_individual_rewrite_1
to
main
February 6, 2024 22:09
webmiche
reviewed
Feb 7, 2024
Comment on lines
+66
to
+68
| pattern.match_and_rewrite(matched_operation, rewriter) | ||
| if not rewriter.has_done_action: | ||
| raise ValueError("Invalid rewrite at current location.") |
There was a problem hiding this comment.
To me, this feels like a case that should have a warning instead of an exception. It feels like this might make it hard to interact with this pass through scripts and stuff.
Though, I guess people consider exceptional control flow for basic stuff acceptable in Python, so this is just a side comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2 out of 4.
Added an arith canonicalisation pattern to use as an example/ starting point to extending arith canonicalisation patterns.