Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and test optional operand and result variables. #2107

Merged
merged 4 commits into from
Feb 23, 2024

Conversation

PapyChacal
Copy link
Collaborator

Stacked on #2106.

Add optional operands and type directives; very similar to the variadic ones. Adds the notion of "variadic-like" to relate to checks added in #2106

@PapyChacal PapyChacal added the core xDSL core (ir, textual format, ...) label Feb 6, 2024
@PapyChacal PapyChacal requested a review from math-fehr February 6, 2024 20:33
@PapyChacal PapyChacal self-assigned this Feb 6, 2024
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: Patch coverage is 93.66197% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 89.50%. Comparing base (51461d6) to head (a7723af).

Files Patch % Lines
xdsl/irdl/declarative_assembly_format.py 92.75% 2 Missing and 3 partials ⚠️
xdsl/irdl/declarative_assembly_format_parser.py 85.18% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
+ Coverage   89.48%   89.50%   +0.01%     
==========================================
  Files         326      326              
  Lines       38873    38983     +110     
  Branches     5754     5773      +19     
==========================================
+ Hits        34787    34890     +103     
- Misses       3288     3292       +4     
- Partials      798      801       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice, thanks a lot <3

@PapyChacal PapyChacal marked this pull request as ready for review February 22, 2024 17:41
Base automatically changed from emilien/declarative-verify to main February 23, 2024 10:53
@PapyChacal PapyChacal force-pushed the emilien/declarative-optionals branch from 039196e to a7723af Compare February 23, 2024 11:02
@PapyChacal PapyChacal merged commit b67530f into main Feb 23, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/declarative-optionals branch February 23, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants