core: add custom attr and prop name support to assembly format #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2123 +/- ##
=======================================
Coverage 90.11% 90.12%
=======================================
Files 296 296
Lines 36734 36758 +24
Branches 5458 5461 +3
=======================================
+ Hits 33103 33127 +24
Misses 2852 2852
Partials 779 779 ☔ View full report in Codecov by Sentry. |
math-fehr
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can either use the python or the irdl name in the custom assembly format, it make sense to me to stick to the IRDL name of things to be portable. Not sure if there's an aspect that I'm missing here.