dialects: (snitch_stream) remove StridedReadOp and LowerStridedWriteOp #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/convert-memref-stream-to-snitch-stream
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
PapyChacal and
adutilleul
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2127 +/- ##
==========================================
- Coverage 90.12% 90.11% -0.02%
==========================================
Files 302 302
Lines 36857 36813 -44
Branches 5471 5472 +1
==========================================
- Hits 33219 33175 -44
Misses 2859 2859
Partials 779 779 ☔ View full report in Codecov by Sentry. |
nazavode
approved these changes
Feb 9, 2024
compor
approved these changes
Feb 10, 2024
…snitch_stream/enable-gets-streams
Base automatically changed from
sasha/snitch_stream/stride-pattern-operand
to
main
February 10, 2024 19:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might as well lower to snitch directly, instead of going through one more snitch_stream operation. It also makes the stream starting more explicit, by returning the streams directly.