dialects: (snitch_stream) reverse bounds and strides in snitch_stream #2139
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the documentation and interpreter implementation of snitch_stream stride patterns in line with the snitch_stream lowering to snitch.
This is a PR with only a functional change in the interpreter, but with consequences on upcoming lowerings from memref_stream to snitch_stream. When I first added snitch_stream and the corresponding interpreter functions, I was under the impression that the snrt functions took bounds and strides from the outermost loop inwards, but it's the reverse. The distinction is now somewhat arbitrary, since we are planning to link to snrt any more, and could actually implement the lowering from snitch_stream to snitch with the inverse order of bounds. I think that we should stick to the current order of bounds, implement the complete lowering first, and then see whether switching the order around would be an improvement.