Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (snitch_stream) add stride pattern attribute #2141

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

superlopuh
Copy link
Member

PR 2/4 of replacing the snitch_stream.stride_pattern op with an attribute

This introduces the new attribute, currently unused

@superlopuh superlopuh added the dialects Changes on the dialects label Feb 12, 2024
@superlopuh superlopuh self-assigned this Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b18b0df) 90.17% compared to head (df804d9) 90.17%.

Files Patch % Lines
xdsl/dialects/snitch_stream.py 89.65% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                                  Coverage Diff                                   @@
##           sasha/snitch_stream/stride-pattern-lowering-helper    #2141      +/-   ##
======================================================================================
- Coverage                                               90.17%   90.17%   -0.01%     
======================================================================================
  Files                                                     305      305              
  Lines                                                   37043    37072      +29     
  Branches                                                 5515     5523       +8     
======================================================================================
+ Hits                                                    33404    33430      +26     
- Misses                                                   2860     2862       +2     
- Partials                                                  779      780       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from sasha/snitch_stream/stride-pattern-lowering-helper to main February 13, 2024 10:06
@superlopuh superlopuh merged commit 28bd269 into main Feb 13, 2024
9 checks passed
@superlopuh superlopuh deleted the sasha/snitch_stream/stride-pattern branch February 13, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants