core: Allow unregistered citizens in a registered dialects #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2161 +/- ##
==========================================
- Coverage 89.38% 89.38% -0.01%
==========================================
Files 317 317
Lines 38534 38530 -4
Branches 5696 5694 -2
==========================================
- Hits 34445 34441 -4
Misses 3287 3287
Partials 802 802 ☔ View full report in Codecov by Sentry. |
superlopuh
approved these changes
Feb 15, 2024
webmiche
reviewed
Feb 15, 2024
|
Ah, I see you link from the devito stuff. I guess that's the usecase 😅 |
|
More generally, without this, it means that any dialect implementing any op or attr, would require any other op or attr to be actually implemented for unregistered interoperability with MLIR. I don't see any bright future for xDSL as a prototyping platform with such a constraint! |
compor
approved these changes
Feb 16, 2024
superlopuh
pushed a commit
that referenced
this pull request
Feb 22, 2024
Currently, when looking for an operation/attribute, even in "allow unregistered dialect" mode, we aggressively error out on an unregistered operation/attribute, if it so happens to have a dialect name of a registered dialect. This commit relaxes this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when looking for an operation/attribute, even in "allow unregistered dialect" mode, we aggressively error out on an unregistered operation/attribute, if it so happens to have a dialect name of a registered dialect. This PR relaxes this.