-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: add linalg.fill #2189
Conversation
As you can see from the CI output, the fill operation in MLIR expects a scalar input, not a tensor. We might want to implement the same verification. The best thing to do would be to look at the MLIR source code to find the verifier for the fill op |
tests/filecheck/mlir-conversion/with-mlir/dialects/linalg/invalid_ops.mlir
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2189 +/- ##
==========================================
+ Coverage 89.36% 89.38% +0.01%
==========================================
Files 316 317 +1
Lines 38413 38522 +109
Branches 5678 5693 +15
==========================================
+ Hits 34328 34433 +105
- Misses 3282 3287 +5
+ Partials 803 802 -1 ☔ View full report in Codecov by Sentry. |
tests/filecheck/mlir-conversion/with-mlir/dialects/linalg/ops.mlir
Outdated
Show resolved
Hide resolved
tests/filecheck/mlir-conversion/with-mlir/dialects/linalg/ops.mlir
Outdated
Show resolved
Hide resolved
tests/filecheck/mlir-conversion/with-mlir/dialects/linalg/ops.mlir
Outdated
Show resolved
Hide resolved
Haven't really checked the custom format in the operation definition in MLIR, but I've found an example in which Line 439 in ae2054d
I'm not sure if this was a mistake or it's just provisional until the cutom format API supports optional groups, but just in case I thought I'd have you know! |
Oh interesting, should be easy to fix, can you please file an issue with this info? |
See #2228. |
No description provided.