Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: Fix inline_asm unitattrs to not be properties #2223

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

JosseVanDelm
Copy link
Collaborator

@superlopuh pointed out that #2203 contains an erroneous implementation of a UnitAttr being implemented as properties. This is incorrect, since upstream prints the UnitAttrs as attributes and properties.
It was a bit confusing because some other ops in the LLVM dialect have the same mistake right now.
This happens under the radar because in testing, properties are printed as attributes.
This PR fixes the inline_asm operation.

@JosseVanDelm JosseVanDelm added enhancement New feature or request dialects Changes on the dialects labels Feb 22, 2024
@JosseVanDelm JosseVanDelm self-assigned this Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ad8f2e0) 89.47% compared to head (da681b2) 89.48%.

Files Patch % Lines
xdsl/dialects/llvm.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2223   +/-   ##
=======================================
  Coverage   89.47%   89.48%           
=======================================
  Files         326      326           
  Lines       38828    38825    -3     
  Branches     5746     5744    -2     
=======================================
  Hits        34741    34741           
+ Misses       3289     3286    -3     
  Partials      798      798           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@JosseVanDelm JosseVanDelm merged commit 836098f into main Feb 22, 2024
10 checks passed
@JosseVanDelm JosseVanDelm deleted the Josse/fix-inline-asm branch February 22, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants