dialects: Fix affine.ParallelOp boundsGroup checks. #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
added
dialects
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
=======================================
Coverage 89.62% 89.62%
=======================================
Files 346 346
Lines 41027 41027
Branches 6096 6096
=======================================
Hits 36771 36771
Misses 3364 3364
Partials 892 892 ☔ View full report in Codecov by Sentry. |
Through errors on an xDSL+MLIR flow I'm working on; will try and add a test sure! |
|
@PapyChacal, any progress on this? |
Yep 👼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current (my 😅) verifier of
affine.parallelis off.boundsGroups work like operandSegmentSizes; it contains the lengths of each group.
The current verifier assumes they work like mappings from each bound to its group.