Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Implement first cases of assembly format optional groups #2239

Merged
merged 11 commits into from
Feb 28, 2024

Conversation

PapyChacal
Copy link
Collaborator

This covers optional groups with no else group, only literal first then element, and optional/variadic operand/result/type anchors. I think this is the most widely used, it enables the typical (`(` $variadic_operand`)`)?

- TypeDirectives are VariableDirectives (discussable)
- ABCs for Optionals and Variadics under VariadicLike
- Define Anchorable
- Implement in VariadicVariableDirective, OptionalVariableDirective.
@PapyChacal PapyChacal added the core xDSL core (ir, textual format, ...) label Feb 27, 2024
@PapyChacal PapyChacal requested a review from math-fehr February 27, 2024 13:58
@PapyChacal PapyChacal self-assigned this Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.49%. Comparing base (d2fa75d) to head (300f5b4).
Report is 2 commits behind head on main.

Files Patch % Lines
xdsl/irdl/declarative_assembly_format.py 94.02% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2239      +/-   ##
==========================================
+ Coverage   89.47%   89.49%   +0.02%     
==========================================
  Files         328      328              
  Lines       39235    39361     +126     
  Branches     5811     5837      +26     
==========================================
+ Hits        35104    35227     +123     
- Misses       3323     3327       +4     
+ Partials      808      807       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PapyChacal PapyChacal marked this pull request as draft February 27, 2024 20:23
@PapyChacal PapyChacal marked this pull request as ready for review February 28, 2024 09:10
@PapyChacal PapyChacal merged commit f648f96 into main Feb 28, 2024
9 checks passed
@PapyChacal PapyChacal deleted the emilien/assembly-optional-group branch February 28, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants