dialects: (hw) Add InnerSymAttr attributes to HW dialect.

[lucjaulmes]

Another hopefully manageable chunk of HW, which introduces the symbol attributes. These are used in many circt dialects (e.g., seq) to define the names then referenced by the InnerRefAttrs and the like.

This is the bit of the symbol rationale that gives details.

This PR also includes a small fix on the tests, simplifying the test file and undoing the over-correction of camel case to snake case on symbol mnemonics (we want those to be compatible with CIRCT).

Thanks a lot to @PapyChacal for all the help in deciphering where CIRCT hides the symbol attr tests.

[codecov]

Codecov Report

Attention: Patch coverage is 94.11765% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 89.52%. Comparing base (720ab7a) to head (4694ff0).

Files	Patch %	Lines
xdsl/dialects/hw.py	93.18%	3 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2251      +/-   ##
==========================================
+ Coverage   89.50%   89.52%   +0.01%     
==========================================
  Files         328      328              
  Lines       39327    39428     +101     
  Branches     5825     5846      +21     
==========================================
+ Hits        35201    35297      +96     
- Misses       3320     3323       +3     
- Partials      806      808       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lucjaulmes]

• Regarding code formatting, the ... on the same line is auto-corrected that way by ruff locally. Can revert but not sure why this is happening? I just made sure I have the correct versions (running python 3.11 though), and am rebased on latest main.
• Regarding coverage, will complete soon. Unfortunately local computing of coverage is off too.

[PapyChacal]

• Regarding code formatting, the ... on the same line is auto-corrected that way by ruff locally. Can revert but not sure why this is happening? I just made sure I have the correct versions (running python 3.11 though), and am rebased on latest main.

  • Regarding coverage, will complete soon. Unfortunately local computing of coverage is off too.

Did you run make in the repository? AFAIU this installs dependencies as expected, i.e. the right versions of toolings.
That said, I recently had a lot of those ... reformatting show up recently, but never had a problem with them. did they trigger CI errors in this case?

[lucjaulmes]

Yes CI failed on e9a0829. I updated from requirements.txt in case there were any chances, but could try a full delete and reinstall, see if that changes anything…

Edit: did that, to no avail. It seems the only difference remaining I can see is python 3.10 vs 3.11

[lucjaulmes]

Updated on latest main & added missing bits.