dialects: (snitch_stream) make snitch_stream parameters go outwards-in #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
JosseVanDelm and
adutilleul
superlopuh
commented
Mar 4, 2024
| @@ -106,11 +106,9 @@ def match_and_rewrite( | |||
| for map, shape in zip(op.indexing_maps, shapes, strict=True) | |||
| ) | |||
| bounds = tuple(bound.data for bound in op.bounds) | |||
| # snitch_stream stride patterns are from innermost out | |||
| # TODO: make consistent | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2294 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 329 329
Lines 39423 39423
Branches 5898 5898
=======================================
Hits 35298 35298
Misses 3266 3266
Partials 859 859 ☔ View full report in Codecov by Sentry. |
AntonLydike
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes things a little less weird for most of the high-level representations, and only treat the ubs and strides as innnermost-out inside the lowering from snitch_stream to snitch.