Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (gpu) Adding gpu.wait op #2298

Merged
merged 6 commits into from
Mar 12, 2024

Conversation

tavakkoliamirmohammad
Copy link
Contributor

This pull request adds the gpu.wait op for GPU asynchronous execution. The gpu.wait op generates a token that can be used to enable asynchronous execution combined with other operations in gpu dialect.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (f2b7418) to head (9fa14a7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2298   +/-   ##
=======================================
  Coverage   89.54%   89.55%           
=======================================
  Files         332      332           
  Lines       39601    39618   +17     
  Branches     5916     5917    +1     
=======================================
+ Hits        35461    35478   +17     
  Misses       3277     3277           
  Partials      863      863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@PapyChacal PapyChacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!
Could tou simply add roundtrip (tests/filecheck/dialects/gpu/ops.mlir) and interoperability (tests/filecheck/mlir-conversion/with-mlir/dialects/gpu/ops.mlir) tests?

@superlopuh superlopuh added the dialects Changes on the dialects label Mar 6, 2024
tavakkoliamirmohammad and others added 2 commits March 6, 2024 11:40
Co-authored-by: Emilien Bauer <papychacal@gmail.com>
Copy link
Collaborator

@PapyChacal PapyChacal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks 😀

@tavakkoliamirmohammad
Copy link
Contributor Author

Thank You! :)

@PapyChacal
Copy link
Collaborator

Feel free to merge when you want 🙂

@tavakkoliamirmohammad
Copy link
Contributor Author

I don't have write access

@tavakkoliamirmohammad
Copy link
Contributor Author

@PapyChacal Would you please commit these changes? (I don't have the write access)

@superlopuh superlopuh merged commit 3472dc1 into xdslproject:main Mar 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants