-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (gpu) Adding gpu.wait
op
#2298
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2298 +/- ##
=======================================
Coverage 89.54% 89.55%
=======================================
Files 332 332
Lines 39601 39618 +17
Branches 5916 5917 +1
=======================================
+ Hits 35461 35478 +17
Misses 3277 3277
Partials 863 863 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Could tou simply add roundtrip (tests/filecheck/dialects/gpu/ops.mlir
) and interoperability (tests/filecheck/mlir-conversion/with-mlir/dialects/gpu/ops.mlir
) tests?
Co-authored-by: Emilien Bauer <papychacal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks 😀
Thank You! :) |
Feel free to merge when you want 🙂 |
I don't have write access |
@PapyChacal Would you please commit these changes? (I don't have the write access) |
This pull request adds the
gpu.wait
op for GPU asynchronous execution. Thegpu.wait
op generates a token that can be used to enable asynchronous execution combined with other operations ingpu
dialect.