Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: move InsertPoint to Rewriter [NFC] #2310

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

superlopuh
Copy link
Member

I'd like to add some helpers to Rewriter to leverage InsertPoint, and right now this would involve a circular reference. Between Rewriter and Builder, it feels like InsertPoint is closer in abstraction to Rewriter anyway.

@superlopuh superlopuh added the core xDSL core (ir, textual format, ...) label Mar 6, 2024
@superlopuh superlopuh self-assigned this Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.50%. Comparing base (b58fd69) to head (98e1a85).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2310      +/-   ##
==========================================
- Coverage   89.53%   89.50%   -0.03%     
==========================================
  Files         329      329              
  Lines       39429    39451      +22     
  Branches     5901     5906       +5     
==========================================
+ Hits        35304    35312       +8     
- Misses       3266     3277      +11     
- Partials      859      862       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see where it's going and I like it

@superlopuh superlopuh merged commit a2f84dc into main Mar 6, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/core/move-insert-point branch March 6, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants