core: use InsertPoint for block inlining #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
AntonLydike,
georgebisbas,
math-fehr,
PapyChacal and
webmiche
superlopuh
commented
Mar 6, 2024
| @@ -147,7 +147,6 @@ def test_inline_block_at_end(): | |||
| "builtin.module"() ({ | |||
| %0 = "test.op"() : () -> !test.type<"int"> | |||
| "test.op"() ({ | |||
| ^0: | |||
There was a problem hiding this comment.
inlined source blocks are now consistently deleted when inlined into another block
There was a problem hiding this comment.
Makes sense to me, that's actually what MLIR does as well!
PapyChacal
approved these changes
Mar 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2311 +/- ##
==========================================
+ Coverage 89.54% 89.56% +0.02%
==========================================
Files 332 332
Lines 39604 39596 -8
Branches 5916 5910 -6
==========================================
+ Hits 35464 35466 +2
+ Misses 3277 3270 -7
+ Partials 863 860 -3 ☔ View full report in Codecov by Sentry. |
compor
approved these changes
Mar 6, 2024
math-fehr
approved these changes
Mar 6, 2024
| @@ -147,7 +147,6 @@ def test_inline_block_at_end(): | |||
| "builtin.module"() ({ | |||
| %0 = "test.op"() : () -> !test.type<"int"> | |||
| "test.op"() ({ | |||
| ^0: | |||
There was a problem hiding this comment.
Makes sense to me, that's actually what MLIR does as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unifies implementations