Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: declarative format variable fix #2313

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

PapyChacal
Copy link
Collaborator

No description provided.

@PapyChacal PapyChacal added minor For minor PRs, easy and quick to review, quickly mergeable core xDSL core (ir, textual format, ...) labels Mar 6, 2024
@PapyChacal PapyChacal requested a review from math-fehr March 6, 2024 17:52
@PapyChacal PapyChacal self-assigned this Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.55%. Comparing base (40b4a68) to head (d261608).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2313   +/-   ##
=======================================
  Coverage   89.54%   89.55%           
=======================================
  Files         332      332           
  Lines       39590    39603   +13     
  Branches     5916     5917    +1     
=======================================
+ Hits        35452    35465   +13     
  Misses       3275     3275           
  Partials      863      863           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arg, I see the problem :/
One other way is to index the operand definition instead, but I agree that getting it from the name seems to be the way to go!
Thanks!

@PapyChacal PapyChacal merged commit 44af987 into main Mar 7, 2024
10 checks passed
@PapyChacal PapyChacal deleted the emilien/assembly-fix branch March 7, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...) minor For minor PRs, easy and quick to review, quickly mergeable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants