Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (linalg) allow for empty results in linalg.fill custom format #2363

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

superlopuh
Copy link
Member

Fixes #2228: linalg.fill shouldn't have a fixed result

CC @gabrielrodcanal

@superlopuh superlopuh added bug Something isn't working dialects Changes on the dialects labels Mar 22, 2024
@superlopuh superlopuh self-assigned this Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.60%. Comparing base (d398151) to head (58663b1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2363   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files         345      345           
  Lines       40691    40691           
  Branches     6050     6050           
=======================================
  Hits        36462    36462           
  Misses       3352     3352           
  Partials      877      877           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Moxinilian Moxinilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish there was some constraints on whether the optional result is there or not but I guess even MLIR does not do that...

@superlopuh superlopuh merged commit 039b266 into main Mar 24, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/linalg/fill-optional-result branch March 24, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dialects Changes on the dialects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linalg.fill shouldn't have a fixed result
2 participants