Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Fix bug in pattern rewriter when ErasedSSAValue is present #2365

Merged
merged 1 commit into from
Mar 24, 2024

Conversation

math-fehr
Copy link
Collaborator

When an operation is deleted, the pattern rewriter adds its operands with 1 use to the worklist of operations to change.
This change checks that these operands are not ErasedSSAValue, otherwise an erased operation would be added to the worklist.

I'm starting to think that the ErasedSSAValue design is bad, I'll be thinking of a way to change this.

@math-fehr math-fehr added the core xDSL core (ir, textual format, ...) label Mar 22, 2024
@math-fehr math-fehr self-assigned this Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.60%. Comparing base (836098f) to head (6dc5fe8).
Report is 106 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2365      +/-   ##
==========================================
+ Coverage   89.48%   89.60%   +0.12%     
==========================================
  Files         326      345      +19     
  Lines       38825    40700    +1875     
  Branches     5744     6051     +307     
==========================================
+ Hits        34741    36471    +1730     
- Misses       3286     3352      +66     
- Partials      798      877      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobiasgrosser tobiasgrosser merged commit 07108d9 into main Mar 24, 2024
10 checks passed
@tobiasgrosser tobiasgrosser deleted the fehr/fix-bug-in-rewriter branch March 24, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core xDSL core (ir, textual format, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants