core: Fix bug in pattern rewriter when ErasedSSAValue is present #2365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an operation is deleted, the pattern rewriter adds its operands with 1 use to the worklist of operations to change.
This change checks that these operands are not
ErasedSSAValue
, otherwise an erased operation would be added to the worklist.I'm starting to think that the
ErasedSSAValue
design is bad, I'll be thinking of a way to change this.