rewriting: Fix TypeConversionPattern recursive support for DictionaryAttr #2374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moxinilian
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2374 +/- ##
=======================================
Coverage 89.63% 89.64%
=======================================
Files 345 346 +1
Lines 40827 40905 +78
Branches 6073 6081 +8
=======================================
+ Hits 36597 36671 +74
- Misses 3347 3350 +3
- Partials 883 884 +1 ☔ View full report in Codecov by Sentry. |
math-fehr
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation of
TypeConversionPatternclaims it supports attribute dictionaries, but does not walk them recursively. This PR fixes this behavior.