Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (onnx) lower onnx.Conv to linalg #2396

Merged
merged 7 commits into from
Apr 4, 2024

Conversation

kayode-gif
Copy link
Collaborator

wip #2395

i used xdsl/tests/filecheck/projects/riscv-backend-paper/bottom_up.mlir to get an idea of how to do it, i feel this is "close"

@kayode-gif kayode-gif added the interpreter xDSL Interpreter label Mar 27, 2024
@kayode-gif kayode-gif requested a review from superlopuh March 27, 2024 22:09
@kayode-gif kayode-gif self-assigned this Mar 27, 2024
@kayode-gif kayode-gif added dialects Changes on the dialects transformations Changes or adds a transformatio and removed interpreter xDSL Interpreter dialects Changes on the dialects labels Mar 28, 2024
Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kayode-gif
Copy link
Collaborator Author

Why not lower to a named op? https://mlir.llvm.org/docs/Dialects/Linalg/#linalgpooling_nchw_max-linalgpoolingnchwmaxop

i guess it was because i dont want to write more interpreter ops, but it may be smoother

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (26d9fe2) to head (a8089e3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2396      +/-   ##
==========================================
+ Coverage   89.67%   89.69%   +0.02%     
==========================================
  Files         345      345              
  Lines       41874    41914      +40     
  Branches     6227     6232       +5     
==========================================
+ Hits        37550    37595      +45     
+ Misses       3410     3405       -5     
  Partials      914      914              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kayode-gif kayode-gif marked this pull request as ready for review April 2, 2024 23:43
@kayode-gif kayode-gif marked this pull request as draft April 3, 2024 11:14
@kayode-gif kayode-gif force-pushed the oke/add-onnx-conv-lowering-op branch from a6578a4 to 7435126 Compare April 3, 2024 11:20
@kayode-gif kayode-gif force-pushed the oke/add-onnx-conv-lowering-op branch from 7435126 to d1728c0 Compare April 3, 2024 11:26
@kayode-gif kayode-gif marked this pull request as ready for review April 3, 2024 11:31
@kayode-gif
Copy link
Collaborator Author

@superlopuh

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great

@kayode-gif kayode-gif merged commit 3245833 into main Apr 4, 2024
10 checks passed
@kayode-gif kayode-gif deleted the oke/add-onnx-conv-lowering-op branch April 4, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants