-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transformations: (onnx) lower onnx.Conv to linalg #2396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not lower to a named op?
https://mlir.llvm.org/docs/Dialects/Linalg/#linalgpooling_nchw_max-linalgpoolingnchwmaxop
i guess it was because i dont want to write more interpreter ops, but it may be smoother |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2396 +/- ##
==========================================
+ Coverage 89.67% 89.69% +0.02%
==========================================
Files 345 345
Lines 41874 41914 +40
Branches 6227 6232 +5
==========================================
+ Hits 37550 37595 +45
+ Misses 3410 3405 -5
Partials 914 914 ☔ View full report in Codecov by Sentry. |
a6578a4
to
7435126
Compare
7435126
to
d1728c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great
wip #2395
i used xdsl/tests/filecheck/projects/riscv-backend-paper/bottom_up.mlir to get an idea of how to do it, i feel this is "close"