dialects: (hw) Add InnerRefNamespaceTrait to HWModuleOp #2406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires InnerRefNamespaceLike. We use abc.ABC to reimplement the upstream mechanics of implementing this with isa<InnerRefNamespaceLike> and InnerRefNamespaceLike::classof() Fixes xdslproject#2402
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2406 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 346 346
Lines 41418 41423 +5
Branches 6175 6175
=======================================
+ Hits 37144 37149 +5
Misses 3372 3372
Partials 902 902 ☔ View full report in Codecov by Sentry. |
Moxinilian
approved these changes
Apr 1, 2024
superlopuh
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires
InnerRefNamespaceLike.We use
abc.ABCto reimplement the upstream mechanics of implementing this withisa<InnerRefNamespaceLike>andInnerRefNamespaceLike::classof()Fixes #2402