dialects: (seq) Add builder and verifier for CompRegOp #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moxinilian
added
enhancement
AntonLydike
requested changes
Apr 4, 2024
xdsl/dialects/seq.py
Outdated
| if (self.reset is not None and self.reset_value is None) or ( | ||
| self.reset_value is not None and self.reset is None | ||
| ): | ||
| raise VerifyException("both reset and reset_value must be set when one is") |
There was a problem hiding this comment.
Our verifier messages usually start with uppercase letters afaik.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2429 +/- ##
=======================================
Coverage 89.70% 89.71%
=======================================
Files 345 345
Lines 42001 42014 +13
Branches 6251 6252 +1
=======================================
+ Hits 37678 37691 +13
Misses 3407 3407
Partials 916 916 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a verifier and a builder to CompRegOp.