Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialects: (hw) Add hw.instance operation #2486

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

Moxinilian
Copy link
Contributor

This PR adds a subset of the hw.instance operation, the dual of hw.module for instantiation.

@Moxinilian Moxinilian added enhancement New feature or request dialects Changes on the dialects labels Apr 22, 2024
@Moxinilian Moxinilian self-assigned this Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.78%. Comparing base (34fb769) to head (9315af2).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2486      +/-   ##
==========================================
- Coverage   89.80%   89.78%   -0.02%     
==========================================
  Files         350      350              
  Lines       42890    43146     +256     
  Branches     6370     6427      +57     
==========================================
+ Hits        38516    38740     +224     
- Misses       3430     3453      +23     
- Partials      944      953       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moxinilian
Copy link
Contributor Author

Codecov you have no idea how happy I am right now.

@PapyChacal
Copy link
Collaborator

Can you add an example with extra attributes on an hw.instance? I think the printer is missing it?

@Moxinilian
Copy link
Contributor Author

Nice catch

@Moxinilian Moxinilian requested review from PapyChacal and removed request for superlopuh April 23, 2024 09:32
Copy link
Collaborator

@lucjaulmes lucjaulmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tiny nits but otherwise LGTM.

xdsl/dialects/hw.py Show resolved Hide resolved
xdsl/dialects/hw.py Show resolved Hide resolved
xdsl/dialects/hw.py Outdated Show resolved Hide resolved
tests/filecheck/dialects/hw/hw_instance.mlir Outdated Show resolved Hide resolved
tests/filecheck/dialects/hw/hw_instance.mlir Outdated Show resolved Hide resolved
@Moxinilian Moxinilian merged commit f010e87 into xdslproject:main Apr 25, 2024
10 checks passed
@Moxinilian Moxinilian deleted the hw-instance branch April 25, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialects Changes on the dialects enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants