-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dialects: (hw) Add hw.instance operation #2486
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2486 +/- ##
==========================================
- Coverage 89.80% 89.78% -0.02%
==========================================
Files 350 350
Lines 42890 43146 +256
Branches 6370 6427 +57
==========================================
+ Hits 38516 38740 +224
- Misses 3430 3453 +23
- Partials 944 953 +9 ☔ View full report in Codecov by Sentry. |
Codecov you have no idea how happy I am right now. |
Can you add an example with extra attributes on an |
Nice catch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny nits but otherwise LGTM.
This PR adds a subset of the hw.instance operation, the dual of hw.module for instantiation.