core: Implement TypedAttribute, leverage in declarative assembly format. #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapyChacal
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2493 +/- ##
=======================================
Coverage 89.78% 89.78%
=======================================
Files 350 350
Lines 43016 43086 +70
Branches 6394 6411 +17
=======================================
+ Hits 38622 38686 +64
- Misses 3447 3448 +1
- Partials 947 952 +5 ☔ View full report in Codecov by Sentry. |
math-fehr
reviewed
Apr 24, 2024
superlopuh
reviewed
Apr 25, 2024
superlopuh
reviewed
Apr 25, 2024
superlopuh
reviewed
Apr 25, 2024
superlopuh
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement TypedAttribute, a baseclass for attributes having a type attribute 🙃 Mirroring the MLIR interface.
This is useful for the declarative assembly format, where when referencing an integer of a known type, we want to parse and print it with its type elided.